Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement | Clear unanswered quick replies when new message arrives #131

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Enhancement | Clear unanswered quick replies when new message arrives #131

merged 2 commits into from
Mar 22, 2024

Conversation

Arjona99
Copy link

@Arjona99 Arjona99 commented Mar 22, 2024 •
edited
Loading

Description

Undesired scenario:

  • A send template message arrives with a set of quick replies for the user
  • The user doesn't select any option
  • A new message arrives without quick replies
  • The previous quick replies options remain visible although there are from the previous message that is not valid anymore

Type of change

  • New feature (non-breaking change which adds functionality)

Media

Video
Screen.Recording.2024-03-21.at.7.59.15.p.m.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Arjona99 Arjona99 self-assigned this Mar 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cmm-apli cmm-apli merged commit cee9e1a into develop Mar 22, 2024
5 checks passed
@Arjona99 Arjona99 mentioned this pull request Mar 22, 2024
Merged
@Arjona99 Arjona99 mentioned this pull request Apr 9, 2024
Merged
cmm-apli added a commit that referenced this pull request Apr 12, 2024
@Arjona99 @cmm-apli @AranGarcia
Release 24.12.01 (#133)
2f6c9e7 
* Fix | enforce event trigger

* adding async

* adding try catch

* clear quick replies from vuex action (#131)

* Fix | Rollback last change (#134)

* Removed Alpine repository for vips

* clear quick replies when new message arrives (#136)

---------

Co-authored-by: Cristina Mariscal <cristina.mariscal@apli.jobs>
Co-authored-by: cmm-apli <100155261+cmm-apli@users.noreply.github.com>
Co-authored-by: Allan Garcia <allan@apli.jobs>
Co-authored-by: Allan Garcia <a.g.jesrez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmm-apli cmm-apli cmm-apli approved these changes

@Behtsa Behtsa Awaiting requested review from Behtsa

Assignees

@Arjona99 Arjona99

Labels
1 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arjona99 @cmm-apli